sharu725 / youtube-embed

Embeds a clickable youtube thumbnail instead of the iframe. Upon clicking, loads the iframe.
https://embed.sveltethemes.dev
36 stars 7 forks source link

UX improvements #2

Closed amr3k closed 2 years ago

amr3k commented 2 years ago

Using overlay that plays the video on click, thus easier for users to play videos on touch devices. Allowing developers to specify the overlay color and transition Updated README with an example of this update Updated index.svelte with a live example

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webjeda/youtube-embed/H2WNftNSFCfSvoHJAyZcVfoSHrWt
✅ Preview: https://youtube-embed-git-fork-416d72-master-webjeda.vercel.app

sharu725 commented 2 years ago

This is so good! Thank you.

amr3k commented 2 years ago

Thank @sharu725 , I'm a big fan ☺️

sharu725 commented 2 years ago

@all-contributors please add @416d72 for design

allcontributors[bot] commented 2 years ago

@sharu725

I've put up a pull request to add @416d72! :tada: