sharu725 / youtube-embed

Embeds a clickable youtube thumbnail instead of the iframe. Upon clicking, loads the iframe.
https://embed.sveltethemes.dev
36 stars 7 forks source link

adds a comment disabling svelte a11y checks for the overlay #32

Closed willgottschalk closed 1 week ago

willgottschalk commented 1 week ago

This closes #30. I read through https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles and didn't find a role that cleanly maps to an overlay. There's a dialog role:

window that separates content or UI from the rest of the web application or page

But the overlay is just a background and doesn't really have it's own content for screen readers

Instead of giving it an aria-role that doesn't match. I'd rather suppress the warning

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
youtube-embed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 10:35pm
willgottschalk commented 1 week ago

The alternative is to add suppression checking in my codebase via https://stackoverflow.com/questions/77518443/disable-certain-a11y-warnings-globally-in-sveltekit

Happy to go either direction

sharu725 commented 1 week ago

Thank you.