search

sharyuwu / optimum-tilt-of-solar-panels

Other
0 stars 0 forks source link

VnV Suggestion: Change symbol "date" to something that indicates duration #30

Closed sorainsm closed 4 years ago

sorainsm commented 4 years ago

Hi Sharon, Just a suggestion, the use of date as a symbol representing a period of time is a little confusing when reading through the document. While it's clear what you're using it for, people may come back to this document and not read it from top to bottom, and so I think changing date to either period or days would imply that it's a duration rather than just a singular date.

image

sharyuwu commented 4 years ago

@sorainsm Thank sora:) This is great advice. I have been struggled a lot with how to make this variable more explicit. I will think about the name you offered. I will leave the issue open to think about it.

smiths commented 4 years ago

@sharyuwu, I think the concept of date and time will become more clear to you when you complete your MIS. I'm fairly sure you will be introducing an ADT for date. Your choice of interface to this ADT will show you what date related calculations you need. To clarify your SRS and VnV plan, you might want to go back and add a date type to these documents.

sharyuwu commented 4 years ago

@smiths Yes, I have followed your advice on adding a data type in my SRS but haven't updated it. I will at a link to this issue after updating my document.

sharyuwu commented 4 years ago

I have added an additional explanation to this confusion. Hope it help!! image

https://github.com/sharyuwu/optimum-tilt-of-solar-panels/blob/master/docs/SRS/SRS.tex#L854 https://github.com/sharyuwu/optimum-tilt-of-solar-panels/blob/master/docs/VnVPlan/SystVnVPlan/SystVnVPlan.tex#L75