search

sharyuwu / optimum-tilt-of-solar-panels

Other
0 stars 0 forks source link

Semantics of setlist #48

Closed caobo1994 closed 4 years ago

caobo1994 commented 4 years ago

I see you use concatenation twice in this function. One is the beginning, and the other one is [day, ...]. I think only one of them is needed, and I suggest that you remove the first one.

sharyuwu commented 4 years ago

Yes, I am working on this module now and this setlist has changed.

https://github.com/sharyuwu/optimum-tilt-of-solar-panels/issues/46 This is what it looks like right now.

image

And the new local function will be called by getdurlist. Please give me feedback on the new local function!! Thank you

caobo1994 commented 4 years ago

This new content is unavailable in your online git repo. Could you push it? Thanks!

sharyuwu commented 4 years ago

Sure:) but I am still continually changing it:)

sharyuwu commented 4 years ago

Yes I HAVE PUSH it. But please notice that I am still working on the documents:)

sharyuwu commented 4 years ago

Extended discussion on https://github.com/sharyuwu/optimum-tilt-of-solar-panels/issues/51