search

shashi / FileTrees.jl

Parallel computing with a tree of files metaphor
http://shashi.biz/FileTrees.jl
Other
88 stars 6 forks source link

Fix compute out of bounds when tree contains non-thunks #22

Closed DrChainsaw closed 4 years ago

DrChainsaw commented 4 years ago

Fixes #21

Maybe there is a nicer way to do this, but I didn't want to disrupt (and think :) )

Its kinda untested beyond trivial trees so I'm a bit relying on the existing test suite.

Oh, also sorry for kinda diluting the contributors list with trivial fixes. Not sure if it is bad open source etiquette or the way things are supposed to be :).

codecov-commenter commented 4 years ago

Codecov Report

Merging #22 into master will decrease coverage by 0.22%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   84.22%   84.00%   -0.23%     
==========================================
  Files           6        6              
  Lines         298      300       +2     
==========================================
+ Hits          251      252       +1     
- Misses         47       48       +1
Impacted Files Coverage Δ
src/parallelism.jl 90.00% <75.00%> (-4.45%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c62e75a...32d5cc4. Read the comment docs.

shashi commented 4 years ago

Thanks! My bad!

I think I fixed this in #11 but forgot to just merge this one fix.

Oh, also sorry for kinda diluting the contributors list with trivial fixes. Not sure if it is bad open source etiquette or the way things are supposed to be :).

Not at all!! Your changes are most welcome! This one is not trivial, it's a major bug haha. Small or big, any contribution is awesome!