search

shashi / FileTrees.jl

Parallel computing with a tree of files metaphor
http://shashi.biz/FileTrees.jl
Other
88 stars 6 forks source link

Remove overwriting of Dagger functions in test #34

Closed DrChainsaw closed 3 years ago

DrChainsaw commented 3 years ago

I just realized that the "overloading" of the Dagger functions in the 'exec with context' test are permanent. This is bound to cause confusing failures in the future so here I think they should be removed even if it makes the test slightly less protective.

I somehow naively thought that all that happens in testset stays in testset, but this is not true for globals.

codecov-commenter commented 3 years ago

Codecov Report

Merging #34 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   84.22%   84.22%           
=======================================
  Files           6        6           
  Lines         317      317           
=======================================
  Hits          267      267           
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a3a1e1...56c1c8d. Read the comment docs.

shashi commented 3 years ago

Yeah. This makes the tests also easy to understand :)