Closed shashi closed 4 years ago
getindex should give subtrees. (it sometimes gives trees that are at the root (e.g. vector getindex).
getindex
but filter should give a tree rooted at the same root.
filter
Move and consolidate functionality thus and make things not redundant.
detach should be redundant given filter, getindex and diff.
detach
diff
Remove it, or make it mean detach(t) = set_parent(t, nothing).
detach(t) = set_parent(t, nothing)
getindexshould give subtrees. (it sometimes gives trees that are at the root (e.g. vector getindex).but
filtershould give a tree rooted at the same root.Move and consolidate functionality thus and make things not redundant.
detachshould be redundant givenfilter,getindexanddiff.Remove it, or make it mean
detach(t) = set_parent(t, nothing).