shashisadasivan / EDMXTrimmer

D365 Finance and operations EDMX trimmer
MIT License
22 stars 12 forks source link

Can't build the project #13

Closed ablizorukov closed 1 year ago

ablizorukov commented 1 year ago

Hi,

I've noticed that after the last merge to master the project can't be builded anymore. I think that some lines were lost during merge, the code below is just to fix the building issue but there is might be something else

Index: EDMXTrimmer/EDMXTrimmer/EdmxTrimmer.cs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/EDMXTrimmer/EDMXTrimmer/EdmxTrimmer.cs b/EDMXTrimmer/EDMXTrimmer/EdmxTrimmer.cs
--- a/EDMXTrimmer/EDMXTrimmer/EdmxTrimmer.cs    (revision fdb45c8719810ff1f499021d9122a8724149d76a)
+++ b/EDMXTrimmer/EDMXTrimmer/EdmxTrimmer.cs    (date 1675779949872)
@@ -166,6 +166,7 @@
             this._xmlDocument.GetElementsByTagName(ACTION).Cast<XmlNode>()
                 .Where(action => !entityTypesFound.Any(entityType => action.ChildNodes.Cast<XmlNode>().
                     Any(childNode => EntityExists(childNode, entityType)))).ToList()
+                .ForEach(n => n.ParentNode.RemoveChild(n));

             // Determine enums to keep
             List<String> enumTypesFound = new List<string>();
Index: EDMXTrimmer/EDMXTrimmer/Program.cs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/EDMXTrimmer/EDMXTrimmer/Program.cs b/EDMXTrimmer/EDMXTrimmer/Program.cs
--- a/EDMXTrimmer/EDMXTrimmer/Program.cs    (revision fdb45c8719810ff1f499021d9122a8724149d76a)
+++ b/EDMXTrimmer/EDMXTrimmer/Program.cs    (date 1675780140874)
@@ -1,3 +1,4 @@
+using System;
 using CommandLine;
 using System.Collections.Generic;
 using System.Linq;
FH-Inway commented 1 year ago

Hi Andrei, thanks for reporting, I will take a look.

In the mean time, you can build the version I have here: https://github.com/FH-Inway/EDMXTrimmer/tree/fh-main Or take the already build package from here: https://github.com/FH-Inway/EDMXTrimmer/releases/tag/latest

FH-Inway commented 1 year ago

You were absolutely right, I messed up the conflict merge for pr #12 , sorry.

shashisadasivan commented 1 year ago

This has been fixed now i assume. Github action to build and release worked fine