search

shashwatak / satellite-js

Modular set of functions for SGP4 and SDP4 propagation of TLEs.
MIT License
902 stars 145 forks source link

misleadingly-named parameter observerCoordsEcf should be observerGeodetic #44

Closed nhamer closed 6 years ago

nhamer commented 6 years ago

nit, documented as observerGeodetic (and Ecf coords don't work as a parameter)

https://github.com/shashwatak/satellite-js/blob/226d8d5520c0cf03a591a6f0bd4ddfd8a1de0965/src/transforms.js#L171

ezze commented 6 years ago

@nhamer, thank you for reporting. I made some naming changes here. Hope it looks better now.