Increased test coverage for fringe cases

shashwatak / satellite-js

Modular set of functions for SGP4 and SDP4 propagation of TLEs.

MIT License

902 stars 145 forks source link

Increased test coverage for fringe cases #84

Closed thkruz closed 3 years ago

thkruz commented 3 years ago

Tried to add some more coverage on the fringe cases. I want to look into issue #75 but would prefer 100% code coverage first.

thkruz commented 3 years ago

Looks like I need to double check the eslint setup...

coveralls commented 3 years ago

Coverage increased (+13.7%) to 96.322% when pulling fb31fb5abf7dcce232d8a99701acabebac3b4462 on thkruz:more-test-coverage into c726d154fed0b555c5fb8637639135ac8210a8af on shashwatak:develop.

ezze commented 3 years ago

@thkruz Wow, cool! Increasing test coverage is what we could only dream about.

ezze commented 3 years ago

@thkruz How are you doing? :) Should we close it?

thkruz commented 3 years ago

@ezze I have been really busy and just now getting back on github/coding. This PR was good to go back in Jan. I would think you want to merge it, not close it.

ezze commented 3 years ago

@thkruz No problems, dude! Can you address my notes regarding toBeCloseTo and compareVectors mentioned above?

thkruz commented 3 years ago

@ezze maybe I am going crazy, but I don't see any notes from you regarding those functions? On my end it shows no reviews of the commits... Can you point me in the right direction?

ezze commented 3 years ago

@thkruz Sorry, my bad. I started code review but didn't submit changes request.

thkruz commented 3 years ago

Had to start PR #91 in order to make the requested changes. Closing this.