search

shatran / card-react

React component for card https://github.com/jessepollak/card
MIT License
133 stars 65 forks source link

Fix: set React as a peerDepencency #15

Closed joeybaker closed 8 years ago

joeybaker commented 8 years ago

This allows the user to determine which version of react they want to use.

shatran commented 8 years ago

Thanks for that @joeybaker. It's probably the better practice to allow the user to use whatever react version they want :). I will merge it and publish it soon.

joeybaker commented 8 years ago

@shatran Thanks for merging, but by setting the minimum react version to 15, you disallow 0.14 users from using this module. Is that intentional? I'm not aware of anything that requires v15 of react for this to work.

shatran commented 8 years ago

@joeybaker didn't you say it will allow users to use whatever version they want?

joeybaker commented 8 years ago

Ermaigawd. I'm the idiot. I thought I set the peer deps right but must have copy/pasted wrong. So sorry!

Will send a correction soon.