search

shatteredsilicon / ssm-submodules

GNU Affero General Public License v3.0
0 stars 2 forks source link

Monitored Instances Page Still Mentions PMM #191

Closed gordan-bobic closed 8 months ago

gordan-bobic commented 10 months ago

In the top left:

PMM / _SSM Monitored Instances

Also, why the underscores at the beginning? Did we inherit that from PMM? Any idea why that's there?

oblitorum commented 10 months ago

Yeah, the underscores are inherited from PMM v1, will remove them.

Also this issue could lead to many relative things that need to be changed, e.g. the PMM tag name of dashboards, pmm keyword in the url

gordan-bobic commented 10 months ago

Noted. I'll make sure I test the dashboard links more thoroughly when we are nearing the release.

gordan-bobic commented 8 months ago

QAN reports this when there are no queries to show:

No data. Please check pmm-client and database configurations on selected instance.

I don't see a mention of this line in the PRs, can you please confirm? It should say:

No data. Please check ssm-client and database configurations on selected instance.
oblitorum commented 8 months ago

Yeah, I noticed that before, and fix it in this commit -> https://github.com/shatteredsilicon/qan-app/pull/32/files#diff-1bc46822a02c346298aed107a9ee699c2acd48ecf6be78301a444b1cd750bc4fL9-R9, it's merged now.

gordan-bobic commented 8 months ago

Great, closing.