shatteredsilicon / ssm-submodules

GNU Affero General Public License v3.0
0 stars 2 forks source link

Failure of pt-visual-explain shouldn't result in no explain return of any kind #194

Closed gordan-bobic closed 10 months ago

gordan-bobic commented 10 months ago

Following on from: https://github.com/shatteredsilicon/ssm-submodules/issues/new Failure of pt-visual-explain should not prevent the return of regular explain output, since that was obviously retrieved to be passed to pt-visual-explain.

As long as the actual (equivalent of)

mysql --raw --batch -e "EXPLAIN $query" $schema

returns something valid, that should be enough to render the regular EXPLAIN output. If pt-visual-explain fails, that is unfortunate, but it shouldn't prevent the return and rendering of the regular explain output.