shatteredsilicon / ssm-submodules

GNU Affero General Public License v3.0
0 stars 2 forks source link

ssm-admin remove shoudn't unnecessarily fail due to missing or broken service configs #201

Closed gordan-bobic closed 9 months ago

gordan-bobic commented 9 months ago

I ran into a peculiar case where following an upgrae from pmm-client-1.17.5 to ssm-client the mysql:queries service got broken. But the more concerning part is that ssm-admin remove was failing due to broken or missing configs, so there was a broken service that could not be removed, and without being removed could not be re-added.

Deleting the service from the web interface allowed ssm-admin remove mysql:queries to succeed.

The remove operation shouldn't be failing if some components are already removed, it should proceed with removing whatever it can find related to that service, from both the server and client sides.