shatteredsilicon / ssm-submodules

GNU Affero General Public License v3.0
1 stars 2 forks source link

Insight / Advisor Dashboard #256

Closed gordan-bobic closed 2 months ago

gordan-bobic commented 3 months ago
oblitorum commented 2 months ago

It looks like the colours of the squares don't match the colour coding legend

In order to make the green blocks visible through the thickness, I made the color half transparent. and because the colors on the left are on top of a dark gray background, and the colors on the right are on top of a green background (those memory blocks), which somehow makes it look different.

image

If we make it non-transparent, they will look just the same, but it will look like this, which is not quite acceptable.

image

Also there is a problem with the current way it shows those thickness - Say max_allowed_packet and tmp_table_size are both 2 GB, their represent rectangles will have the exact same size, e.g. there are actually 2 rectangles in the highlight area in then below image, one for max_allowed_packet and another for tmp_table_size, but one of them is 'hidden'. We may need to think of a way to solve this, e.g. divide the rectangle, or privode a second action so one can select which rectangle to see.

image

Considering the above issues, maybe we can use a different way to represent those allocated memory, like showing different allocated memory directly on the memory blocks:

image

We can still have the popup when we hover over the memory blocks, also currently one memory block represents 16 MB, say binlog_stmt_cache_size is 5 MB, less than one memory block, and then we can make the relevant memory block smaller, like the one in the above image.

What do you think? One of the downside could be that it seems a little 'colorful', not sure if using a darker color schema will make it better.

gordan-bobic commented 2 months ago

Can we make it stretch to the full surface area of the graph? That would improve resolution, possibly to a point where the problem becomes irrelevant. Importance of allocation is proportional to theme size. So if one of the tiny allocation disappears below the noise floor, it doesn't really matter.

oblitorum commented 2 months ago

You mean like this? Yeah, we can do that I think. Which mean the size that a memory block represents will be different depending on what total allocated memory size is, it could be 8 MB if total allocated memory is 8 GB, or 4 MB if allocated memory is 4 GB

image

gordan-bobic commented 2 months ago

I think that looks better. Or we make the squares smaller, e.g. 4x4 or 8x8 pixels.

oblitorum commented 2 months ago

OK, it looks like this now

image

If this looks ok, then this PR is ready to be merged.