search

shauli-ravfogel / rlace-icml

34 stars 3 forks source link

Train used instead of dev in solve_adv_game #2

Open FabienRoger opened 2 years ago

FabienRoger commented 2 years ago

I think this line is wrong and should pass X_dev & y_dev as "X_dev/y_dev" parameters.

https://github.com/shauli-ravfogel/rlace-icml/blob/2d9b6d03f65416172b4a2ca7f6da10e374002e5f/rlace.py#L188

X_dev & y_dev are not used inside the whole function.

FabienRoger commented 2 years ago

Do you know if this error was present in the code you used to run your experiments?