search

shaun-chiang / rn-android-pip

React Native Android Picture-in-Picture Library.
MIT License
17 stars 24 forks source link

Several small improvements #4

Closed Yatanvesh closed 4 years ago

Yatanvesh commented 4 years ago
  1. Accommodate RN 0.60 and above projects, bump build tool version and targetSdkVersion.
  2. Decrease minSdkVersion to 19, and in doing so added a check in enterPictureInPictureMode to ignore sdk versions 23 and below.
  3. Change package identifier to com.reactpiplibrary as com.reactlibrary is already taken by another library, which causes release build to fail.
  4. Update readme
Yatanvesh commented 4 years ago

I'm using this in my project, it took me a while to get it working, but when it did, I decided to do it properly and commit. Although simple, thank you for creating this library

Yatanvesh commented 4 years ago

Hi, added functionality to configure aspect ratio( Keeping android SDK level restriction in mind), and auto PIP switch functionality option when app goes out of focus, updated readme (A typo went into prev commit, fixed it in next)