search

shaun-chiang / rn-android-pip

React Native Android Picture-in-Picture Library.
MIT License
17 stars 24 forks source link

_reactNativeAndroidPip.default.configureAspectRatio is not a function. #9

Closed astroana closed 3 years ago

astroana commented 3 years ago

I tried changing aspect ratio to AndroidPip.configureAspectRatio(2, 3);

but I'm getting this error _reactNativeAndroidPip.default.configureAspectRatio is not a function. (In '_reactNativeAndroidPip.default.configureAspectRatio(2, 3)', '_reactNativeAndroidPip.default.configureAspectRatio' is undefined)

RN ver: 0.63.4 Android SDK ver: 30 min SDK ver: 24

astroana commented 3 years ago

I got it now, but not sure if this is the right thing to do.

the npm package is not updated the other features is not defined in the npm package but is updated in the repo, install the git repo

npm install --save https://github.com/shaun-chiang/rn-android-pip

and just change reactlibrary to reactpiplibrary in (folder name change in the repo)

----------------------------
mainApplication.java
----------------------------
import com.reactpiplibrary.RNAndroidPipPackage;

and do the rest in the documentation. all features will now work.