search

shaunagm / WelcomeBot

Other
35 stars 43 forks source link

Fixed "Bot does not recognize fast name change" bug #21

Closed aaparella closed 10 years ago

aaparella commented 10 years ago

Records name that was initially used to log in with, and greets with new name. Works for multiple name changes within the silence minute.

Also fixed a typo in the greeting message ("though" -> "thought")

shaunagm commented 10 years ago

Thanks @aaparella! For some reason I didn't get notified that there was a pull request so I just saw this - I'll take a look at it later today.

shaunagm commented 10 years ago

Hey @aaparella, I have one suggestion for a change, otherwise it looks great!

aaparella commented 10 years ago

The bot now ignores the usage of NICK in messages, though it kind of is a bit of a hack. Perhaps a generic method could be written that generally ignores the use of keywords in messages could be written? Either way, committed changes address that problem.

shaunagm commented 10 years ago

Thanks, @aaparella! Looks great, but I still want to test it and won't have the time for a couple days. Should be merged early this week.

Feel free to add your suggestion for a new method to the issue tracker. :)