search

shaunagm / WelcomeBot

Other
35 stars 43 forks source link

Fix for issue #12 - Fast name change tracking #28

Closed aaparella closed 10 years ago

aaparella commented 10 years ago

Fixed issue in which if a user changed their ID within the wait time prior to greeting, they were greeted with their old name.

Also fixed a typo ("though" -> "thought")

shaunagm commented 10 years ago

Hi @aaparella! Sorry it took me so long to reply to this - I was trying to refactor the code and add tests, which I just finished doing. Would you like to re-write your contribution so that it fits into the new format? If not, I can do so for you.

aaparella commented 10 years ago

I'll be able to rewrite it tomorrow.

shaunagm commented 10 years ago

Great! To be clear, there's no rush - as long as you can rewrite it within the next few weeks, I'll be happy. :)