shaunagm / WelcomeBot

Other
35 stars 43 forks source link

Fix for issue #1 Add rules to catch Un-identified names #29

Closed aaparella closed 10 years ago

aaparella commented 10 years ago

Now ignores nicks differentiated only by trailing digits, or by a location specifier (e.g alex and alex|work). Added function is_nick_not_known to allow for easily expanding upon these rules. Also added nicks.csv to gitignore, as I would assume we would want the nicks.csv list to be specific to each installation, not the master repository.

shaunagm commented 10 years ago

Hi @aaparella - as I said in your other PR, I was trying to refactor the code and add tests, which I just finished doing. Would you like to re-write your contribution so that it fits into the new format? If not, I can do so for you