search

shaunagm / WelcomeBot

Other
35 stars 43 forks source link

Fix for issue #12 : Update upon name change prior to being greeted #37

Closed aaparella closed 10 years ago

aaparella commented 10 years ago

Added an additional check for name change messages for newcomers, and added logic to update nick for those users. Currently only updates users in newcomers, could be updated to add changed name to known users if such functionality is desired.

shaunagm commented 10 years ago

@aaparella, I am happy to merge this now. Are you interested in adding a test for this behavior in the new test suite? If so, let me know if you'd like me to pair with you on it or answer any questions. If not, I will go ahead and merge, and write the test myself.

aaparella commented 10 years ago

I'm afraid I don't really know how the test suite works as is, so you may want to do that. I'll look into how it works for use in the future.

shaunagm commented 10 years ago

Totally understand. I've added a ticket regarding documenting the test suite: https://github.com/shaunagm/WelcomeBot/issues/38. Will try to get to that soon, and you can tell me whether it needs more info. :)

Fixes https://github.com/shaunagm/WelcomeBot/issues/12