search

shaunagm / WelcomeBot

Other
35 stars 43 forks source link

Remove unnecessary file from repository #39

Closed shaunagm closed 9 years ago

shaunagm commented 10 years ago

This error.log was mistakenly included in the repo. Can someone get rid of it?

artLopez commented 9 years ago

I deleted the error.log file and stored the error.log into .gitignore.

shaunagm commented 9 years ago

Excellent! Can you submit those changes back to the repository as a pull request?

Edited: Nevermind, you are way ahead of me. :)

artLopez commented 9 years ago

Just submitted a pull request!

shaunagm commented 9 years ago

You are halfway there! The gitignore looks awesome. But the pull request doesn't capture your deletion of the file. In order for git to remember that the file was deleted, you need to tell git that it was deleted. To do this, use the command:

git rm $file

And then commit as usual. :)

shaunagm commented 9 years ago

closes #39

shaunagm commented 9 years ago

Thank you @artLopez!

artLopez commented 9 years ago

No problem @shaunagm . Always enthusiastic on contributing!