shaunagm / WelcomeBot

Other
35 stars 43 forks source link

WelcomeBot having difficulty with newcomers who quit then rejoin before wait-time is over #45

Open shaunagm opened 9 years ago

shaunagm commented 9 years ago

Just observed this happening:

[14:10:42] -- jerrychen (~jerrychen@$place) has joined #openhatch
[14:11:00] jerrychen: Hello
[14:11:58] -- jerrychen (~jerrychen@$place) has left #openhatch
[14:12:11] -- jerrychen (~jerrychen@$place) has joined #openhatch
[14:14:26] shauna: hi jerrychen
[14:17:12] WelcomeBot: Welcome jerrychen!  The channel is pretty quiet right now, so I thought I'd say hello, and ping some people (like shauna, paulproteus, and marktraceur) that you're here.  If no one responds for a while, try emailing us at hello@openhatch.org or just try coming back later.  FYI, you're now on my list of known nicknames, so I won't bother you again.

Initial thoughts: when someone quits before being welcomed, they should be treated as new when they return. Maybe somethings going wrong with that part of the program and the old newcomer object is not being removed?

This bug should probably be reproduced before we go further.