search

shaunagm / actionrising

0 stars 0 forks source link

skip login to speed up tests #285

Open AlexRiina opened 7 years ago

AlexRiina commented 7 years ago

This takes the functional test suite from 5:20s -> 3:40s for me. There are a few failures in the functional tests, but they're the same across develop and this branch for me

AlexRiina commented 7 years ago

@praccu

AlexRiina commented 7 years ago

I have a few more things on my TODO list regarding test speed:

The the fixtures don't seem to contribute very much time. Swapping PhantomJS for chrome has a few issues still regarding the datatables filters. I think --parallel works pretty well for the tests

AlexRiina commented 7 years ago

on this branch with some extra page loads removed, with whitenoise removed, debug=False, sqlite memory, and no migrations, I get 3:22 total

AlexRiina commented 7 years ago

Bunch of random testing related changes in this branch. I think I already made a8f660f but couldn't find evidence of it with git log --all

AlexRiina commented 7 years ago

Huh weird. I have only the middle one which I think Paul fixed in another branch

On Wed, May 24, 2017, 2:55 PM Shauna Gordon-McKeon notifications@github.com wrote:

@shaunagm commented on this pull request.

This looks like it introduces new errors to me, specifically:

ERROR: test_logged_out_landing_page (functional_tests.test_mysite.TestBasics)

Traceback (most recent call last): File "/home/shauna/Desktop/shared/git/resist/actnow-test/functional_tests/test_mysite.py", line 24, in test_logged_out_landing_page landing_page.signup.click() AttributeError: 'NoneType' object has no attribute 'click'

FAIL: test_display_slates (functional_tests.test_slates.TestSlateList)

Traceback (most recent call last): File "/home/shauna/Desktop/shared/git/resist/actnow-test/functional_tests/test_slates.py", line 41, in test_display_slates self.assertEquals(self.slates_table.first_row_date.text, "Fri Dec 02") AssertionError: u'Mon Nov 28' != 'Fri Dec 02'

FAIL: test_navbar_by_login_status (functional_tests.test_mysite.TestBasics)

Traceback (most recent call last): File "/home/shauna/Desktop/shared/git/resist/actnow-test/functional_tests/test_mysite.py", line 14, in test_navbar_by_login_status self.assertEquals(len(base_page.navbar_links), header_links + footer_links) AssertionError: 14 != 11

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shaunagm/actionrising/pull/285#pullrequestreview-40119213, or mute the thread https://github.com/notifications/unsubscribe-auth/AD5gKmEiVjpSWnBP8FD8GgzsMCaEi5Hkks5r9H0KgaJpZM4Nhzo2 .

shaunagm commented 7 years ago

@presleyp could you run the tests on this branch again and see if you get the same errors I do?