search

shaunagm / actionrising

0 stars 0 forks source link

Constants #301

Closed ghost closed 7 years ago

ghost commented 7 years ago

Hi! Here's some refactoring that pulls various constants out, and adds a new mechanism for including constants.

I also snuck a test-flake-fix in (sometimes the trackers order was changing, which would cause a unit-test to fail).

I also snuck some minor formatting in (keeping stuff under 80 lines), then got overwhelmed and decided to wait on doing more.

Best to look at these grouped by commit, because otherwise it'll be a bit much to keep track of.

shaunagm commented 7 years ago

A few small issues, but overall this looks great to me. In addition to running tests and poking around, I also made sure to check the emails & they appear to be working just fine.

ghost commented 7 years ago

@shaunagm Thanks for catching that! Should be good to go.

ghost commented 7 years ago

Oh ugh. I totally forgot about the contributor doc. Shall I re-roll this PR with the proper naming &c?

shaunagm commented 7 years ago

Not sure what you mean re: "proper naming &c". If you mean branch naming, no worries, it's more for convenience than anything else.

ghost commented 7 years ago

Yeah, I meant branch naming. Okay!