search

shaunlxw / pe

0 stars 0 forks source link

removetagall with multiple tags ignores invalid tags (where no students have the tag) #10

Open shaunlxw opened 4 months ago

shaunlxw commented 4 months ago

Replicate:

  1. tag any student with t/B
  2. removetagall t/A
  3. 'removetagall t/A t/B`

Step number 3 succeeds without error message. This allows user to have typo in one of the tags and not removing that tag, without any error message.

image.png

image.png

soc-se-bot commented 4 months ago

Team's Response

No details provided by team.

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: Not sure how it is unclear when the steps to reproduce is also given.. First screenshot given above shows that there are no persons with tag A. Second screenshot shows the command removetagall t/A t/B succeeds although there is no persons with tag A, which is a bug as this behaviour should not be expected. Last sentence "This allows user to have typo in one of the tags and not removing that tag, without any error message" explains further problems associated with the bug.

As further explanation of further problems related to the bug:

Initial state of app (note Alex has tag A and Charlotte has tag B)

image.png

Intended action: remove tags A and B Input command: removetagall t/AA t/B (note the typo of t/AA instead of t/A) Result:

image.png

Command succeeds without removing the non existent tag AA, and fails silently (for the removal of tag A).