Open shaunlxw opened 4 months ago
The input provided is clearly invalid and does not follow the correct command format that is described in the UG. Furthermore, the error message shown also displays the correct command format that should be provided. In this case, since a character was provided for the WEEK_NUMBER
parameter instead of an integer, it is indeed an incorrect command format.
Severity changed to Low
since it does not affect normal operations of our product, and the error would not be encountered at all if the user followed our UG closely.
Team chose [response.Rejected
]
Reason for disagreement: Command format refers to the number and order of parameters, while input validation refers to whether the given value of input is within the valid constraints. This issue introduces invalid inputs instead of invalid command format.
The input provided is clearly invalid and does not follow the correct command format that is described in the UG.
In the example inputs given above, the input is invalid, but the command format is in fact correct. The command format for marka (and similarly for unmarka) is given as marka INDEX WEEK_NUMBER
in which both example inputs given above satisfy.
In the example inputs given above, in 1, a character was given instead of integer. In 2, an integer was given but not a valid week number. The error message in both of these cases are inaccurate as it says invalid command format when format is valid. Comparing this output with the command marka 1 1
, it should output a similar error message of "The week provided is invalid".
Similar to #11,
Input: