shaunlxw / pe

0 stars 0 forks source link

UG redo command notes #17

Open shaunlxw opened 4 months ago

shaunlxw commented 4 months ago

UG mentions that "Redo command must be issued immediately after an undo command". This is not accurate from testing as the below is allowed.

Steps:

  1. marka 1 3
  2. undo
  3. list
  4. redo

Might mislead user that they cannot redo their command that changed data after doing a list command

nus-pe-bot commented 4 months ago

Team's Response

Severity VeryLow as it does not affect normal operations at all. UG should have been phrased better to accurately describe the behaviour of the redo command.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Not just purely cosmetic, as it can affect the user's usage of the app in the scenario described below.

Steps:

  1. User input add n/John m/A1234567X tl/thejohn e/john@example.com
  2. User input undo
  3. User input list (to check the results of the undo, since undo does not change the view to show the whole unfiltered view)
  4. User realizes that he wants to add back John, but assumes he cannot call redo since it isn't immediately after an undo command. He will then need to retype add n/John m/A1234567X tl/thejohn e/john@example.com again, decreasing the efficiency of the use of the app.

In hindsight, it might be possible to downgrade the severity to low. However, to note that medium is still possible as it should be quite common for user to call list after undo to check the results of the undo as stated in step 3 above, causing user to think they cannot use the redo command after list, and have to retype the whole command again to redo the action.