search

shaunlxw / pe

0 stars 0 forks source link

edit command: inaccurate error message when multiple tags given with a blank tag #5

Open shaunlxw opened 4 months ago

shaunlxw commented 4 months ago

Input:

  1. edit 9 t/ t/friend, or
  2. edit 9 t/ t/

image.png

image.png

nus-se-script commented 4 months ago

Team's Response

The error message is indeed correct, because a blank is not alphanumeric. It is also further stated in our UG that the TAG should only contain alphanumeric characters and spaces.

image.png

Severity Low because it only appears in very rare situations when users try to input blank tags.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In the UG, the below is stated for edit command.

image.png

This means blank tags are allowed, as can also be tested by the command edit 1 t/ that succeeds. This means the above two commands given should either succeed, or should output an error message specifying "No other tag parameters should be entered after a blank tag parameter t/". The blank tag is intentional by the user in an attempt to remove all the student's tags, and the issue lies with specifying additional tag fields along with the blank tag (that isn't disallowed according to the UG). The error message is not accurate since it does not address the issue of the additional tag fields given with the blank tag.

Hence it is a bug since the UG specifically mentioned that this can be done, and error message on failure doesn't specify accurately what is wrong with the above mentioned commands.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This can happen more than rarely because it is specifically stated in the UG, and users will be expected to test it out/use it. ![image.png](https://raw.githubusercontent.com/shaunlxw/pe/main/files/9ab43b8d-e8b0-4011-bb0f-497515f79fa4.png) E.g. user wants to remove all tags, then add a new tag `t/friend`, which leads to the command `edit 1 t/ t/friend` which fails unexpectedly and outputs an inaccurate error message.