Add-invariant-for-missing-data-logging - Githubissues

shauns / react-d3-radar

React-based Radar chart for D3

MIT License

53 stars 32 forks source link

Add-invariant-for-missing-data-logging #5

Closed wmyers closed 6 years ago

wmyers commented 6 years ago

Why is this change necessary?

If a falsy data prop is passed in to a Radar component then a deep React rendering error occurs.

How does it address the issue?

Adding invariant (for meaningful errors in non-PRODUCTION envs) to log if data is passed with a falsy value.

What side effects does this change have?

None

How was it tested?

Should pass test suite

wmyers commented 6 years ago

should be on fork