Unrecognizable colors in simple terminal

[fjbaldon]

https://imgur.com/a/UoDv8Aq

Attached is a screenshot where #include isn't being displayed correctly. I've patched st with st-no_bold_colors-0.8.1.diff and st-solarized-both-20220617-baa9357.diff .

[shaunsingh]

Does st support termguicolors?

[fjbaldon]

I'm not on solarized rn but yes. Running :termguicolors changes some colors in st

[towry]

[stefumies]

Same here on Mac

[rzeigler]

To chime in, this seems to show good colors for me with background=light.

[cultab]

I can replicate this in windows terminal, and wezterm

It seems to not be st specific and affects all filetypes (in lua filetypes variables are affected instead of #defines).

[peterlvilim]

I'm also hitting this. Light seems to work fine but having trouble with dark. On mac and tried kitty and alacritty. Have tried messing with various different options but haven't found anything yet.

[peterlvilim]

I think I maybe found the problem. I opened a pull request #18 with some example fixes but looking for feedback

[Sleepful]

+1, I can confirm that @peterlvilim's is much more readable.

Notice the grey letters, those were impossible to read:

Using Kitty terminal on OSX, having the same issues everyone described.

[Sleepful]

for comparison:

[peterlvilim]

I have a bunch of commits on my local machine cleaning up various things with dark mode beyond the example diff. It doesn’t fix everything quite yet but been fixing as I notice. Will try to open a pull request with it in next few days.

[lytex]

Commit 34c2245a6ddfd85766f6127768f6b04b0ae2f84a which is the one I had pined before, doesn't have this issue