search

shaunsingh / solarized.nvim

Port of the Solarized colorscheme for vim, written in lua, with treesitter support.
GNU General Public License v2.0
178 stars 37 forks source link

Not sure if colors are right on st; what can I do to help ? #3

Open ghost opened 3 years ago

ghost commented 3 years ago

Hello. I'm running suckless st, latest commit + st-solarized-light-20190306-ed68fe7, st-anysize-0.8.4 and st-bold-is-not-bright-20190127-3be4cf1 patches. I'm not sure if the colors are ok, especially this "cyan". I've been using solarized light for many years and I've never actually seen it.

https://share.dmca.gripe/2LyM0QL8JI3vzRFN.png

This is also present on a non-customized alacritty.

https://share.dmca.gripe/ewyZxWnaPrjvzGrr.png

shaunsingh commented 3 years ago

The cyan color is definitely an issue and not part of the theme. What's happening is that the built-in regex highlighting is either incorrectly putting the cyan color, or I forgot to define an attribute and so its using cyan (which iirc is the default fallback color)

Its a high priority issue I'm planning to take a look at soon. the fixes should be merged into main sometime this week. In case you want to take a look as well, the code that you would need to look at is here: https://github.com/shaunsingh/solarized.nvim/blob/master/lua/solarized/theme.lua

EPadronU commented 2 years ago

How I've dealt with this

-- Fix https://github.com/shaunsingh/solarized.nvim/issues/3
vim.cmd("highlight Identifier ctermfg=13 guifg=" .. require("solarized.colors").purple)

image