search

shauryauppal / PyWhatsapp

Python Automation using selenium & Scheduling of messages and media
https://www.linkedin.com/in/shaurya-uppal
Apache License 2.0
455 stars 159 forks source link

Added functionality to auto download photos #26

Closed Contrevien closed 5 years ago

Contrevien commented 5 years ago

The contact should have some history of photos or the script will fail.

@shauryauppal Please review Probably closes #24

shauryauppal commented 5 years ago

@Contrevien will check it tomorrow. Also recheck line number 93.

Contrevien commented 5 years ago

@shauryauppal It is function's Dogtag which explains what the function does, dunno why it's popping error because the script is working fine

shauryauppal commented 5 years ago

Why is this an issue? This message is emitted when a string statement is found, but which doesn't have any semantic purpose other than documenting the surrounding code. It can also be a potential problem, if the original intent was to write a docstring.

def foo(self): """This is a docstring.""" """This is not and it's superfluous, it could be rewritten as comments."""

shauryauppal commented 5 years ago

Line 93

shauryauppal commented 5 years ago

Sorry but I still have not got time to run from your repo will try to run tomorrow and will merge. I am sure you have done this nicely. For the error can't we add a try catch or something so that is the image is not visible it skips that image or something. The script should not stop. @Contrevien

shauryauppal commented 5 years ago

All the class names are changed by WhatsApp. Download no more works in hardcoded class names.

Adding Xpaths to class names would have been better.