Open nitinkumar30 opened 1 year ago
Are you checking this @shauryauppal? Would you like me to change anything?
@shauryauppal , Is this PR merged?
I have approved it. Looks good to me but before merging. I wanted to do a code run
On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.***> wrote:
@shauryauppal https://github.com/shauryauppal , Is this PR merged?
— Reply to this email directly, view it on GitHub https://github.com/shauryauppal/PyWhatsapp/pull/92#issuecomment-1296262146, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.***>
Also you missed to change requirements.txt for new library install
On Sun, 30 Oct 2022 at 7:41 PM, Shaurya Uppal @.***> wrote:
I have approved it. Looks good to me but before merging. I wanted to do a code run
On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.***> wrote:
@shauryauppal https://github.com/shauryauppal , Is this PR merged?
— Reply to this email directly, view it on GitHub https://github.com/shauryauppal/PyWhatsapp/pull/92#issuecomment-1296262146, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.***>
I have approved it. Looks good to me but before merging. I wanted to do a code run … On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.> wrote: @shauryauppal https://github.com/shauryauppal , Is this PR merged? — Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.>
Sure, thanks.
Also you missed to change requirements.txt for new library install On Sun, 30 Oct 2022 at 7:41 PM, Shaurya Uppal @.> wrote: … I have approved it. Looks good to me but before merging. I wanted to do a code run On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.> wrote: > @shauryauppal https://github.com/shauryauppal , Is this PR merged? > > — > Reply to this email directly, view it on GitHub > <#92 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM > . > You are receiving this because you were mentioned.Message ID: > @.***> >
So sry, should I raise a new PR or you'll do it on your own?
Please make the change with correct library version
On Sun, 30 Oct 2022 at 7:46 PM, Nitin Kumar @.***> wrote:
Also you missed to change requirements.txt for new library install On Sun, 30 Oct 2022 at 7:41 PM, Shaurya Uppal @.
> wrote: … <#m-7749873979663347661> I have approved it. Looks good to me but before merging. I wanted to do a code run On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.> wrote: > @shauryauppal https://github.com/shauryauppal https://github.com/shauryauppal , Is this PR merged? > > — > Reply to this email directly, view it on GitHub > <#92 (comment) https://github.com/shauryauppal/PyWhatsapp/pull/92#issuecomment-1296262146>,
or unsubscribe > https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . > You are receiving this because you were mentioned.Message ID: > @.***>
So sry, should I raise a new PR or you'll do it on your own?
— Reply to this email directly, view it on GitHub https://github.com/shauryauppal/PyWhatsapp/pull/92#issuecomment-1296270776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZO5D5LJHADRQMS5WMLWFZ7M7ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.***>
As discussed, I've tried implementing the ' No need to download web driver ' feature enhanced with the updated README file. Refer to Issue #91 for the same. Thanks. Kindly put the tag of hacktoberfest2022 in this.