shauryauppal / PyWhatsapp

Python Automation using selenium & Scheduling of messages and media
https://www.linkedin.com/in/shaurya-uppal
Apache License 2.0
455 stars 159 forks source link

Pull request for Issue #91 #92

Open nitinkumar30 opened 1 year ago

nitinkumar30 commented 1 year ago

As discussed, I've tried implementing the ' No need to download web driver ' feature enhanced with the updated README file. Refer to Issue #91 for the same. Thanks. Kindly put the tag of hacktoberfest2022 in this.

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=92&src=https%3A%2F%2Fgithub.com%2Fshauryauppal%2FPyWhatsapp)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

nitinkumar30 commented 1 year ago

Are you checking this @shauryauppal? Would you like me to change anything?

nitinkumar30 commented 1 year ago

@shauryauppal , Is this PR merged?

shauryauppal commented 1 year ago

I have approved it. Looks good to me but before merging. I wanted to do a code run

On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.***> wrote:

@shauryauppal https://github.com/shauryauppal , Is this PR merged?

— Reply to this email directly, view it on GitHub https://github.com/shauryauppal/PyWhatsapp/pull/92#issuecomment-1296262146, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.***>

shauryauppal commented 1 year ago

Also you missed to change requirements.txt for new library install

On Sun, 30 Oct 2022 at 7:41 PM, Shaurya Uppal @.***> wrote:

I have approved it. Looks good to me but before merging. I wanted to do a code run

On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.***> wrote:

@shauryauppal https://github.com/shauryauppal , Is this PR merged?

— Reply to this email directly, view it on GitHub https://github.com/shauryauppal/PyWhatsapp/pull/92#issuecomment-1296262146, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.***>

nitinkumar30 commented 1 year ago

I have approved it. Looks good to me but before merging. I wanted to do a code run … On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.> wrote: @shauryauppal https://github.com/shauryauppal , Is this PR merged? — Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.>

Sure, thanks.

nitinkumar30 commented 1 year ago

Also you missed to change requirements.txt for new library install On Sun, 30 Oct 2022 at 7:41 PM, Shaurya Uppal @.> wrote: … I have approved it. Looks good to me but before merging. I wanted to do a code run On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.> wrote: > @shauryauppal https://github.com/shauryauppal , Is this PR merged? > > — > Reply to this email directly, view it on GitHub > <#92 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM > . > You are receiving this because you were mentioned.Message ID: > @.***> >

So sry, should I raise a new PR or you'll do it on your own?

shauryauppal commented 1 year ago

Please make the change with correct library version

On Sun, 30 Oct 2022 at 7:46 PM, Nitin Kumar @.***> wrote:

Also you missed to change requirements.txt for new library install On Sun, 30 Oct 2022 at 7:41 PM, Shaurya Uppal @.

> wrote: … <#m-7749873979663347661> I have approved it. Looks good to me but before merging. I wanted to do a code run On Sun, 30 Oct 2022 at 7:12 PM, Nitin Kumar @.> wrote: > @shauryauppal https://github.com/shauryauppal https://github.com/shauryauppal , Is this PR merged? > > — > Reply to this email directly, view it on GitHub > <#92 (comment) https://github.com/shauryauppal/PyWhatsapp/pull/92#issuecomment-1296262146>,

or unsubscribe > https://github.com/notifications/unsubscribe-auth/AE3FQZMUDRJKUIU4OSH2GXTWFZ3N3ANCNFSM6AAAAAAQ2MCPMM . > You are receiving this because you were mentioned.Message ID: > @.***>

So sry, should I raise a new PR or you'll do it on your own?

— Reply to this email directly, view it on GitHub https://github.com/shauryauppal/PyWhatsapp/pull/92#issuecomment-1296270776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FQZO5D5LJHADRQMS5WMLWFZ7M7ANCNFSM6AAAAAAQ2MCPMM . You are receiving this because you were mentioned.Message ID: @.***>