search

shavitush / bhoptimer

A bunnyhop timer plugin for Counter-Strike: Source, Counter-Strike: Global Offensive and Team Fortress 2.
https://timer.shav.it
GNU General Public License v3.0
230 stars 94 forks source link

Added map reroll to Shavit-MapChooser and necessary update to phrases #1184

Closed MicrowavedBunny closed 1 year ago

MicrowavedBunny commented 1 year ago

Really crude and messy code but i believe this functions properly. Would love feedback.

rtldg commented 1 year ago

The mapchooser thing & ghost thing should be in separate branches / prs.

Also the reroll should use a convar to enable/disable. Probably disabled by default since people dont' like change.

MicrowavedBunny commented 1 year ago

Everything mentioned has been remedied.

MicrowavedBunny commented 1 year ago

Very cool idea - mostly code style issues. Have you tested this out?

It functions as you would expect i have tested it.

MicrowavedBunny commented 1 year ago

All issues have been addressed and updated. Tested the new build and everything seems to function as intended.

MicrowavedBunny commented 1 year ago

Noticed a new issue will look into it. Nominations aren't showing.

MicrowavedBunny commented 1 year ago

Nomination issue is fixed (removed a line that wasnt needed.) Also, map loop issue fixed by uncommenting the clearrtv().

MicrowavedBunny commented 1 year ago

it is possible to have this re-roll selected if no vote it the winning vote causing it to bug out