shavonneg / pe

0 stars 0 forks source link

Application still uses AddressBookParser instead of using ClinicMate #19

Open shavonneg opened 2 months ago

shavonneg commented 2 months ago

Not all instances of AddressBook have been removed from the application and application still uses AddressBookParser and other AddressBook functions instead of it being ClinicMate

Screenshot 2024-04-19 at 17.17.20.png

nus-pe-script commented 2 months ago

Team's Response

Hi, we have indeed AddressBookParser in our code, and we don't feel that it is incorrect to put the diagram in this way. We want to display the diagram exactly as how we implemented it in our code.

Thank you for your understanding :)

Screenshot 2024-04-20 at 10.43.36 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for pointing that out! However, what I am trying to say is that it is inconsistent to be using addressbook code inside your application and hence it does not meet the coding quality, as shown below:

Screenshot 2024-04-24 at 13.11.46.png

Instead, addressbook code should be replaced with ClinicMate code and naming convention.