search

shawfactor / lh-email-registration

Streamlines user registration in the backend by removing redundant fields and replaces usernames with email addresses
0 stars 0 forks source link

+ Modifier #1

Open jb510 opened 9 years ago

jb510 commented 9 years ago

One issue I've run into when doing this without a plugin is that + modfiers are legal in email addresses, but not in WordPress user names. So if you use an email address like me+test@domain.com wordpress' username filter objects and says it's invalid.

I don't know if you've accounted for this in the plugin, but you should, either by changing WordPress' validator to all + or validating and providing a meaningful error when someone tries to use it.

For refrence my ancient neglected trac ticket: https://core.trac.wordpress.org/ticket/23430

shawfactor commented 9 years ago

Jon,

I haven't had a problem with this. the plugin sql replaces the username with the email address after the user registers or updates its profile so emails with modifiers do go into the db. I have tested those emails when logging in and wordpress doesn't seem to mind.

Pete