Comment Example Doesn't Have Correct Number of Variables

shawnbot / topogram

Continuous area cartograms with d3 and TopoJSON

MIT License

326 stars 131 forks source link

Comment Example Doesn't Have Correct Number of Variables #16

Open emeeks opened 10 years ago

emeeks commented 10 years ago

In the commented out example of how to use the code it only refers to topology (and not also the geometry) variable:

var features = cartogram(topology);

timelyportfolio commented 10 years ago

@emeeks Are you working on this? I have been working on an adaptation for rCharts. I discovered quickly that it is based on a very old version of topojson. I made some quick changes here to use version 1 of topojson, but this requires some slight changes to the code. I believe it could be easily fixed to drop in with no required changes.

shawnbot commented 10 years ago

Hi guys, pull requests are much appreciated. I'm taking care of a newborn right now and don't have solid stretches of time to fix these issues. Thanks for looking out!

shawnbot commented 9 years ago

@timelyportfolio are you interested in submitting a pull request with your TopoJSON update?

timelyportfolio commented 9 years ago

honestly forgotten what I did, but will plan to dig up. Examples from that experiment.

http://timelyportfolio.github.io/rCharts_cartogram/world_usopen_mayer.html http://timelyportfolio.github.io/rCharts_cartogram/world_usopen.html

timelyportfolio commented 9 years ago

@shawnbot I should be able to work on it this week

timelyportfolio commented 9 years ago

I have a working version with example using topojson 1.6.19. Let me know if you deem pull-requestable.