search

shawnbrown / datatest

Tools for test driven data-wrangling and data validation.
Other
294 stars 13 forks source link

Add pytest framework trove classifier #41

Closed obestwalter closed 6 years ago

obestwalter commented 6 years ago

Adding the trove classifier will signal that datatest also acts as a pytest plugin. This will also help https://plugincompat.herokuapp.com to find it and list it as a plugin and do regular installation checks.

For further details see this recently merged PR from hypothesis: https://github.com/HypothesisWorks/hypothesis/pull/1306

shawnbrown commented 6 years ago

Thanks for linking to the Hypothesis pull-request and conversation. Datatest is in a similar position--datatest is not a pytest plugin but it does contain a pytest plugin.

I think this addition makes sense but I want to make sure that it shows up as passing on the plugincompat app--despite the disclaimer at the top of the app, I'd rather have datatest not listed than be shown as broken. Datatest, as a whole, is not strictly compatible with pytest's recommended plugin guidelines.

But if I'm reading plugincompat's OVERVIEW correctly, without a tox.ini file, the app will auto-generate one and the plugin will count as passing if it successfully installs.

P.S. The unbundled version of the plugin (pytest-datatest) is a separate package that conforms to the pytest plugin guidelines.

shawnbrown commented 6 years ago

Merged!

obestwalter commented 6 years ago

Hi @shawnbrown, those guidelines apply if you want to migrate a plugin into the pytest-dev organization, so no problem there.