search

shawnchin / jquery-cron

A jQuery plugin to provide a simplified interface for users to specify cron entries
http://shawnchin.github.io/jquery-cron
MIT License
177 stars 118 forks source link

Custom Values - Modified to allow for re-setting of custom values. Use c... #13

Closed farnsy closed 10 years ago

farnsy commented 11 years ago

Custom Values - Modified to allow for re-setting of custom values. Use case: use plugin to set value, save to database, need to reload when viewing web page again. Still does not validate cron string. fixed a number of syntax errors, and applied coding standards (i.e. variable naming etc.)

shawnchin commented 10 years ago

Thanks for submitting this pull request. Would it be possible to resubmit the changes without the programming-style related changes, e.g. the renaming of variables to match a different convention, or white space related changes?

I appreciate that code as it stands is not quite an exemplar of clean JS code, but it is a convention I'm used to. Also, it distracts from the feature change you're proposing and makes it harder for me to review and do an automatic merge.

I'll be closing this request as it stands, but please do not hesitate to resubmit with a pull request focussing on a specific feature.

If you feel strongly against the coding standards I use, feel free to submit a separate pull request with only coding standards changes and quoting a documented standard it matches. This will not only help with validating the change but will also form a baseline that all contributors can use for further changes.

Many thanks.