search

shawnchin / jquery-cron

A jQuery plugin to provide a simplified interface for users to specify cron entries
http://shawnchin.github.io/jquery-cron
MIT License
177 stars 118 forks source link

jquery-cron with support for 'N minutes' for cron entry #5

Closed lowks closed 12 years ago

lowks commented 12 years ago

We have added support for cron that in minutes essentially entries that look like '5/* * * * *'. Do you want to add that into your jquery-cron?

Thanks.

shawnchin commented 12 years ago

Thanks for the pull requests.

I'm afraid I can't do an automerge. The diff shows lots of formatting/whitespace changes which makes it hard to identify what's actually been done.

I'll have a closer look and merge it by hand when I get a chance to.

Many thanks.

shawnchin commented 12 years ago

I finally got a chance to have a closer look at your changes.

While I can see how this will be useful for some users, at present it is not quite in line with what I'm trying to achieve with jquery-cron. i.e. "Every everyNmins at every 40 minute" doesn't read naturally and is therefore less intuitive with users unacquainted with cron.

I'm closing this pull request for now, but I'll continue to explore ways to incorporate your ideas into the code. Many thanks for sharing your changes.

lowks commented 12 years ago

Yeah, I am going to maintain this branch as we use your code, but then we have a need where we need to specify cron jobs running every N minutes.