shawnnlimm / pe

0 stars 0 forks source link

d/DATE_TIME field date range can be improved #4

Open shawnnlimm opened 5 months ago

shawnnlimm commented 5 months ago

Description

Since the app allows clinic managers to handle appointments, it is not very useful for the app to allow users to input past dates, especially the year 1819 (when computers are not even invented yet)

Steps to reproduce

  1. Execute the command add n/hanni pham p/87654321 a/999A t/friend d/06/02/1819 10am-12pm

Expected Behaviour

App should reject this person and throw an error, since we should'nt be able to create an appointment in the past.

Actual Behaviour

New person added successfully.

image.png

Label elaboration

Severity: Low, since it is a very rare situation/unlikely to happen. BugType: FeatureFlaw, since it a product design issue.

nus-pe-bot commented 5 months ago

Team's Response

It is possible that a clinic would be migrating past records. We picked 1819, since that is the founding date of Singapore by Sir Stamford Raffles.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** I disagree that the severity should be VeryLow, since VeryLow severity should only be reserved for cosmetic problems, and the issue stated, while it might be `response.NotInScope`, clearly does not fall under cosmetic problems. ![image.png](https://raw.githubusercontent.com/shawnnlimm/pe/main/files/f01cfb85-0605-42aa-8d54-603f10880fac.png)