shawnnlimm / pe

0 stars 0 forks source link

2 appointments at the same date and time allowed #6

Open shawnnlimm opened 5 months ago

shawnnlimm commented 5 months ago

Description

The current implementation allows 2 people to have an appointment at the exact date and time, which might be problematic (unless the clinic has multiple doctors, and each person is assigned to a different doctor)

Steps to reproduce

  1. Execute add n/hanni pham p/87654321 a/999A t/friend d/tdy 10am-12pm
  2. Execute `add n/johndoe p/87654320 a/888A t/friend d/tdy 10am-12pm

Expected Behaviour

Adding of john doe rejected, since the appointment slot is already assigned to hanni pham

Actual Behaviour

add command executed successfully, with 2 people having the same appointment

image.png

Label elaboration

Severity: Low, since it is unlikely to affect normal operations.

BugType: FeatureFlaw, since it is unlikely 2 people can be assigned to the same appointment timeslot (unless the clinic has multiple doctors, and each person is assigned to a different doctor)

soc-se-bot commented 5 months ago

Team's Response

This is not a feature flaw, this is intended behavior; clinics can have multiple doctors, allowing multiple patients to book an appointment in the same time slot. This is stated under our UG’s Known Issues section, point 2: … “we are working with the assumption that there are multiple doctors at the clinic to attend to different patients.”

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** I disagree that it is of `severity.VeryLow` since it is not purely a cosmetic issue, because it is inconvenient for a user to differentiate between appointments happening at the same time but with different doctors. A clinic manager might need to know which patient is assigned to which doctor.