shawnpong / pe

0 stars 0 forks source link

No return arrow for activation bar #16

Open shawnpong opened 7 months ago

shawnpong commented 7 months ago

image.png this sequence diagrams have parts that do not have a return arrow after the activation bar

image.png

soc-se-bot commented 7 months ago

Team's Response

Missing return arrows

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Group storage sequence diagram confusing

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


image.png Sequence diagram does not return?


[original: nus-cs2113-AY2324S2/pe-interim#1693] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Indeed some of the return arrows are missing

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I disagree with this bug as the original bug(group storage confusing sequence diagram), I am both talking about a entirely different sequence diagram as well as the bug where the sequence diagram is confusing as it is not only errorneous, it is so long that it is being cut off by the pages. This is in general bad documentation practice as it makes it hard for the reader to understand how the program was designed.

The currrent bug(No return arrow for activation bar) specifies a characteristic of the current sequence diagram not having return activation arrows. This does not even include the multitude of other errors such as missing activation bars, image.png and random return arrow image.png

As such, I feel that this bug should not be counted as a duplicate, but a separate bug, and with the other bugs that I have pointed out, this bug should even be classified as a severity.medium truth be told, as it is entirely errorneous and can confuse the reader even more.