<string>.decode() doesn't take keyword arg on python2.6

shawnsi / docker-rpmbuild

Docker wrapper for rpmbuild

MIT License

18 stars 5 forks source link

<string>.decode() doesn't take keyword arg on python2.6 #23

Closed blalor closed 9 years ago

blalor commented 9 years ago

rpmbuild.build:main fails on python 2.6.6 because line.decode doesn't accept the encoding keyword arg. It does work on python2.7; not sure how to reconcile that with python3.

https://github.com/shawnsi/docker-rpmbuild/blob/master/rpmbuild/build.py#L75

shawnsi commented 9 years ago

I'm not sure on best approach here. Maybe a try/except clause to handle python 2.6?

Will accept a pull request that resolves the issue but I don't need this fixed myself.