shawntabrizi / rust-state-machine

A tutorial for building a Polkadot SDK-like state machine written from scratch in Rust.
https://www.shawntabrizi.com/rust-state-machine/
MIT License
56 stars 18 forks source link

Dot Code School Suggestion: Feedback for Section 3 - Chapter 2 #14

Closed animehacker closed 2 months ago

animehacker commented 3 months ago

Good tutorial. Just a very minor point, self.block_number is an implicit return so doesn't need the ; semicolon at the end (actually keeping it caused an error for me) but your answer checker wanted to have it.

I don't know if this is actually something worth mentioning and I'm new to Rust, maybe the compiler is stricter than it used to be.

shawntabrizi commented 3 months ago

@animehacker I can't find the code you are suggesting should be fixed. Can you clarify specifically the code that is in the tutorial that should be changed?

shawntabrizi commented 2 months ago

going to close this, feel free to reopen if you have a chance to respond