shawntabrizi / substrate-collectables-workshop

A guided tutorial for building an NFT marketplace with the Polkadot SDK
https://www.shawntabrizi.com/substrate-collectables-workshop/
MIT License
236 stars 101 forks source link

Math check on Storage Hash Fingerprint section #193

Closed Madalosso closed 1 day ago

Madalosso commented 1 day ago

https://github.com/shawntabrizi/substrate-collectables-workshop/tree/master/steps/11#hash-fingerprint

For context, a 32-byte hash has 2^32 different possible outputs. This is nearly as many atoms as there are in the whole universe!

Shouldn't this be 2^256 instead?

shawntabrizi commented 1 day ago

@Madalosso haha yes :)

Do you want to submit a PR? or I can do it :)

Madalosso commented 1 day ago

I had this one opened for a few days https://github.com/shawntabrizi/substrate-collectables-workshop/pull/191 But today I realized that I was probably doing the change targeting the wrong branch (mdbook). I can create a new one soon with the fix :)

Madalosso commented 1 day ago

@shawntabrizi, there it is. Thanks for the workshop, It was very useful to learn with a hands-on approach

shawntabrizi commented 1 day ago

thanks for your feedback and contribution!