search

shawntabrizi / substrate-collectables-workshop

A guided tutorial for building an NFT marketplace with the Polkadot SDK
https://www.shawntabrizi.com/substrate-collectables-workshop/
MIT License
236 stars 101 forks source link

Two oddities for declaring a struct? #91

Closed JoshOrndorff closed 5 years ago

JoshOrndorff commented 5 years ago

https://github.com/shawntabrizi/substrate-collectables-workshop/blob/master/1/storing-a-structure.md#defining-a-custom-struct mentions "two oddities". I can't figure out how to link to a specific line in an md file, so let this screenshot suffice.

image

Are the two oddities

  1. Encode
  2. Decode

Or was it supposed to be

  1. Encode and Decode
  2. #[cfg_attr(feature = "std", derive(Debug))]
shawntabrizi commented 5 years ago

The two oddities i believe are meant to be the Using Generics and Derive Macro sections.

Must have been at some point that we added that last sentence and messed it all up. Will fix.

shawntabrizi commented 5 years ago

Should be patched, let me know if it is more clear now or can be better improved.