search

shawntoffel / ann_wrapper

A ruby client for the Anime News Network API
https://rubygems.org/gems/ann_wrapper
MIT License
4 stars 3 forks source link

Adding mangas #6

Closed luizbafilho closed 10 years ago

luizbafilho commented 10 years ago

Hi,

In this pull request I'm adding the mangas fetching. I saw that you only fetch animes so... I've implemented the manga fetching.

I tried to not change any previous behavior. The only change I've made that modifies the method's interface is the fetch_titles, that were receiving default parameters and now is a hash, which makes possible change the request passing just what you really want to change without having to add unnecessary parameters.

All tests are passing and I implemented new ones to cover the manga fetching.

Please, feel free to review and make any comments to improve the code.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.26%) when pulling aae7c79f40d6453c2fae68c62069be488a32bb20 on luizfilho:adding-mangas into fe7ad3ec6ce8cc55642451e1841cf727550200d8 on Getkura:dev.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.26%) when pulling 9c25d0e171327bbee4311a42fda85ccf0ca3afea on luizfilho:adding-mangas into fe7ad3ec6ce8cc55642451e1841cf727550200d8 on Getkura:dev.

shawntoffel commented 10 years ago

Thanks @luizfilho! Looks good! I'll go ahead and merge this into dev. Thanks for providing tests and updating the service stub.